wxGUI: Integrate Grapical Modeler into single window layout #3003
Conversation
wenzeslaus
changed the title
landam
force-pushed
the
gmodeler_panel
branch
from
ede7cdf
to
f6545f3
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
It looks like there are some other missing imports:
gmodeler/canvas.py:170:23: F405 'GUI' may be undefined, or defined from star imports: gmodeler.dialogs, gmodeler.model
gmodeler/canvas.py:173:24: F405 'GraphicalModelerGrassInterface' may be undefined, or defined from star imports: gmodeler.dialogs, gmodeler.model
and there are more probably...
It would be a good idea to get rid of the star imports and test flake8 on this.
Addressed by cd78874 |
Thanks, it would be good idea to remove the ignored errors from the .flake8 config file. |
Yes, done in c1c010f |
|
When I open the modeler in the single-window layout, I have some issue with the gmodeler icons. They seem invisible until I drag the mouse over them (see the attached screencast). When I click on another window, all of them appear. Screencast.from.6.4.2024.13.59.55.webm@landam @petrasovaa: Does it happen to you in this PR too? It might be just my local issue so if you don't encounter this problem, I will not block the PR and try to find the solution myself later. |
Thanks for testing. I am not aware of this issue, it never happened to me. See screencast below. Screencast.from.2024-04-06.20-33-29.webmIn your screencast I also don't see any tabs. So it seems that also other widgets from the gmodeler panel have the same issue. @pesekon2 Which wxPython version do you have? |
You are right. I see the same behaviour in tabs. They all appear at once once I go there with the mouse there.
4.2.1. It should be the newest version. Python 3.10.12. |
No clue. Python: 3.11.8 |
Then if nobody else encounters the same issue, I will assume it is a problem at my side. I will not block this PR then (but cannot approve either, as I don't see the same weird behaviour in the old-school gmodeler). I didn't find any other issue with the PR. |
I also tested this PR (university GIS.lab solution) on Python 3.10.12 (with wxPython 4.2.1). No problem detected. So it's mystery to me. |
It works for me as well (Ubuntu wxPython 4.2.0, Python 3.11.4). I have seen this behavior before, but it's a mystery to me as well. |
landam
dismissed
lindakarlovska’s stale review
Since your review the PR changed significantly.
Screencast.from.2023-11-08.12-05-31.webm
Implemeneted:
Not implemented (will be solved in subsequent PRs):
Related changes in API:
canvasandpanels)display/maplike classes/methods/variables renamed (eg.MapNotebookrenamed toMainNotebook, ...)